docs(angular): use type annotations instead of casting - #1433
Closed
harry-whorlow wants to merge 5 commits into
Closed
harry-whorlow wants to merge 5 commits into
harry-whorlow wants to merge 5 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit bf1186c.
☁️ Nx Cloud last updated this comment at |
harry-whorlow
marked this pull request as ready for review
April 20, 2025 19:41
Member
|
Ahh, sorry @harry-whorlow for not catching this prior to a closed PR. I'm in favor of type annotations; what does casting bring to us otherwise? |
Contributor
Author
|
@crutchcorn It wasn't so much as me closing it in favour of casting, I'm for annotations too, I just didn’t want to bother the other maintainers with it for now 🙂 But, I can reopen it |
Member
|
Closing this as I don't see the arguments for it much. Just trying to clean up our PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following some remarks from twitter, and as discussed in the maintainers channel we should avoid casting in the docs. This pr removes the casting defaultValues in examples and docs.